Closed mrariden closed 1 month ago
Attention: Patch coverage is 66.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 56.03%. Comparing base (
cc4e62c
) to head (21789ec
). Report is 33 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
cellpose/io.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When using
io.masks_flows_to_seg()
the iteration over the arguments when the input is a list of images did not succeed and fails quietly. I adjusted the iteration to correctly iterate through the arguments.Resolves:
904
894
Remaining issue: in CP2 the arguments for
diams
andfile_names
are switched in order compared to CP3. It shouldn't matter if the keywords are used but order-based calls toio.masks_flows_to_seg()
will be wrong between the versions. The order cannot be switched without removing the default argument fordiams
, since there isn't a default forfile_names
.Possible solution: set the default
diams = None
since it is used in the .npyest_diam
key. Currently it is set to a default of 30, which may not be correct either.