MoveOnOrg / giraffe

MoveOn CSS from 2018 rebrand
1 stars 1 forks source link

LTE Redesign Styles #299

Closed codygordon closed 2 years ago

codygordon commented 2 years ago

See: https://github.com/MoveOnOrg/ak-template-set/pull/1025

Mocks: https://www.figma.com/file/apOUxfrz5gAJhePGcFyUJ3/Letter-to-Editor-Redesign

View live: https://act.moveon.org/lte/write-letter-test_QA_PAGE https://act.moveon.org/lte/write-letter-test_QA_PAGE/?action_id=525134649&akid=.34578681.PIuw1r&ar=1&rd=1

sjwmoveon commented 2 years ago

The way it's done elsewhere is using js to remove the d-none class.

Sophie

On Wed, Feb 23, 2022 at 12:08 PM Cody Gordon @.***> wrote:

@.**** commented on this pull request.

In src/styles/pages/_lte.scss https://github.com/MoveOnOrg/giraffe/pull/299#discussion_r813120753:

@@ -0,0 +1,219 @@ +body.lte {

  • a {
  • cursor: pointer;
  • }
  • .hidden {

@sjwmoveon https://github.com/sjwmoveon d-none doesn't work for me because it has !important on it. Im using this to hide elements on render, but then use JS to show them, which doesn't seem to work if the CSS is display: none !important.

— Reply to this email directly, view it on GitHub https://github.com/MoveOnOrg/giraffe/pull/299#pullrequestreview-891401611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5HYNQSCLWY3ZJGSFWL24LU4UICVANCNFSM5OZQ3OXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>