Closed technicalex closed 2 years ago
@strangeways, thanks for your review! I have addressed all comments. I compared the main.css
files generated before and after my latest changes, and saw only inconsequential differences (like lowercase vs. uppercase letters in hex color codes, or #FFFFFF
instead of #FFF
). I've attached the files for your examination (with the .txt extension, because GitHub doesn't support .css). The newest file is also uploaded to S3, so it will be pulled whenever you use the ?template_set=after-actions-thank-you
parameter.
Since MoveOn is closed tomorrow, this is the last day of the week, and I don't want to deploy changes right before the long weekend in case of any unexpected issues. Please feel free to deploy these changes when you're back in the office, or I can!
after-actions-thank-you-after.txt after-actions-thank-you-before.txt
Changes to support new styling on Survey Thank You pages.
These changes are compiled to: https://s3.amazonaws.com/actionkit.moveon.org/static/stylesheets/after-actions-thank-you.css
The styling changes interact with templateset changes in the after-actions-thank-you branch of the ak-template-set repository.
To test, you can apply the
template_set=after-actions-thank-you
parameter to any page, and both the template set changes and the new stylesheet will be applied. You can confirm using Developer tools that the correct stylesheet is being applied.