MovingBlocks / DestinationSol

Official continuation of Destination Sol, the great fun little arcade space shooter from http://sourceforge.net/projects/destinationsol/ Modules live at https://github.com/DestinationSol/
Apache License 2.0
326 stars 122 forks source link

Two objects placed inside of themselves #299

Open NicholasBatesNZ opened 6 years ago

NicholasBatesNZ commented 6 years ago

This issue is the culmination of everything contained in the issues #54 #56 and #117. Each individual issue identified what was thought to be an independent issue of Asteroids spawning inside of each other and then star ports doing the same thing. After witnessing myself two ships stuck inside of each other, it is clear that we have a more general placement issue rather than what was initially thought.

screen_shot_2018-02-28_at_10 44 03_am

90 was merged as a band aid fix for #56 and #238 attempted to do the same thing but for #54

What needs to be done now is investigate the placement logic (this can be started by looking at those PRs) and find a more general solution.

"I've come across an asteroid that was stuck within a much larger asteroid today, sadly bouncing around, unable to escape his captor." - grauerkoala

"When the counterparts of two star ports are somewhat close to each other, those star ports can overlap in such a bad way that it's not possible to tell which one you end up in. I'm guessing that this has to do with the general concept of the positioning of star ports in relation to their home planet, which may require some (but not too much) rethinking of said concept." - grauerkoala

"The placement logic seems able to flip out if there are three star gates too close together. Original report on Google+ by saya orang. Probably happens rarely enough to have hidden this long. May need to tweak at the solar system config to try replicating it." - Cervator

Adrijaned commented 6 years ago

Also, StarPorts might spawn basically at the spawnpoint. Someone look into the placement logic for that too, please.