Official continuation of Destination Sol, the great fun little arcade space shooter from http://sourceforge.net/projects/destinationsol/ Modules live at https://github.com/DestinationSol/
Apache License 2.0
325
stars
122
forks
source link
feat: upgrade the groovyw system to be closer in sync with Terasology #634
This is a very optimistic and quick PR that essentially drops in most the latest Groovy utility from Terasology (for instance leaves out facades and the init task) so we can use it to fetch libs (to go with #633) - it also pulls in all other recent related changes, good or bad, hopefully more working than not. In some cases (like common.groovy) it is a lot and I honestly haven't even semi-thoroughly eyeballed the diff - just trusting that since it works with TS it'll work with DS
I tried some quick search and replace for basic differences between TS and DS. I've probably still missed bits or erased some DS-specific details. Feel free to poke around and find some of all the things :-)
Tested with:
groovyw lib get Gestalt (and validating with gradlew engine:dependencies to see that source Gestalt is used)
Note: does not actually compile, am guessing due to a version diff in the default branch you get vs what DS develop uses - likely doesn't matter for this PR
groovyw module get TutorialGalaxyGeneration (I already had warp - @BenjaminAmos should we move your other test module into the DS org? I couldn't spot it, but recall it)
groovyw module create MyNewModule (made some asset subdirs, probably not all the right ones)
Then refreshed Gradle a time or two to make sure there weren't any obvious errors.
If digging deeper surely some problems will show up, for instance groovyw lib list doesn't work as the GitHub paging API changed - pretty sure that's broken in TS as well. I'm trying to not spend too much effort on this as we have a potentially reworked Groovy utility system that entirely replaces the current setup.
This is a very optimistic and quick PR that essentially drops in most the latest Groovy utility from Terasology (for instance leaves out facades and the init task) so we can use it to fetch libs (to go with #633) - it also pulls in all other recent related changes, good or bad, hopefully more working than not. In some cases (like
common.groovy) it is a lot and I honestly haven't even semi-thoroughly eyeballed the diff - just trusting that since it works with TS it'll work with DSI tried some quick search and replace for basic differences between TS and DS. I've probably still missed bits or erased some DS-specific details. Feel free to poke around and find some of all the things :-)
Tested with:
groovyw lib get Gestalt(and validating withgradlew engine:dependenciesto see that source Gestalt is used)developuses - likely doesn't matter for this PRgroovyw module get TutorialGalaxyGeneration(I already had warp - @BenjaminAmos should we move your other test module into the DS org? I couldn't spot it, but recall it)groovyw module create MyNewModule(made some asset subdirs, probably not all the right ones)Then refreshed Gradle a time or two to make sure there weren't any obvious errors.
If digging deeper surely some problems will show up, for instance
groovyw lib listdoesn't work as the GitHub paging API changed - pretty sure that's broken in TS as well. I'm trying to not spend too much effort on this as we have a potentially reworked Groovy utility system that entirely replaces the current setup.