MovingBlocks / DestinationSol

Official continuation of Destination Sol, the great fun little arcade space shooter from http://sourceforge.net/projects/destinationsol/ Modules live at https://github.com/DestinationSol/
Apache License 2.0
326 stars 123 forks source link

NUI talk screen #639

Closed BenjaminAmos closed 2 years ago

BenjaminAmos commented 2 years ago

Description

This pull request converts the Talk screen to NUI. It should functionally identically to before, although there may be some minor visual differences.

Before

image

After

image

Testing

Notes

Mystic-Slice commented 2 years ago

Although, I stumbled upon a new bug. Two NUI menus can be opened at the same time. This should not be allowed. But seeing that it is not isolated to this particular PR, It would make sense to fix this after merging PRs #636 #638 and #639.

https://user-images.githubusercontent.com/73862377/154794401-7aeaf202-7e7c-47d6-a60b-d239e92e36dc.mp4

Another thing you can observe here is that when I open Inventory by clicking Items, the Mercs button just works like a close button for the Inventory. It does not make sense to me. I would want the Inventory to close and the Mercenary screen to open. This is not a bug caused by NUI. The menus work the same way in the develop branch also (the old UI).

BenjaminAmos commented 2 years ago

This was replaced by #667.