MovingBlocks / DestinationSol

Official continuation of Destination Sol, the great fun little arcade space shooter from http://sourceforge.net/projects/destinationsol/ Modules live at https://github.com/DestinationSol/
Apache License 2.0
325 stars 122 forks source link

fix #650: Sound Volume Button works correctly now #651

Closed Mystic-Slice closed 2 years ago

Mystic-Slice commented 2 years ago

Description

Fix issue #650

Testing

Working video

https://user-images.githubusercontent.com/73862377/154787178-9a229865-920e-4903-bfac-c2bb9109d8a2.mp4

Pre Pull Request Checklist:

Mystic-Slice commented 2 years ago

Thanks for fixing this!

By the way, I found another bug whilst testing this. If you change the sound settings in the in-game menu and then exit to the main menu, then the sound values in the main menu options will not have changed. I'd suggest setting the initial values in an overridden onAdded method.

Hey! Thnkx for the review! I have fixed the problem of the volume buttons not being in sync. Should work as expected now.

Note: I have not added the Map Pan Speed and Input Mode buttons in the onAdded method considering that these settings can be changed only in the Options screen and so will not cause any discrepancies