Closed BenjaminAmos closed 1 year ago
I've been testing this in some older (pre-2.0) releases and the ability seems quite strong even then. It's certainly too strong in 1.5.0
and has quite an effect still in 1.1.0
. This makes me wonder if this is really a bug at all? The knockback code doesn't really seem to have changed since the game's initial source release.
This is what happens:
I think it's a bug. The fix is included with the new tutorial.
What you were trying to do
When playing as the
Imperial Small
ship, I was attempting to attack a small miner ship.What actually happened
The miner's knockback ability sent both ships flying apart at an absurd speed. My ship got completely crushed by a collision with a nearby asteroid.
How to reproduce
Game version
develop
Log details
No response
Operating System
Windows
Additional Info
You can find the knockback settings for the small miner ship here.
https://github.com/MovingBlocks/DestinationSol/blob/fa2a67e059b8bbd6d7a25836d04d999ffb0b860b/modules/core/assets/ships/minerSmall/minerSmall.json#L5-L9
I don't think it's related to this though. The force applied seems different when flying a larger ship instead. I suspect that the issue may be caused because we're not scaling the knockback force by the player ship's mass.
https://github.com/MovingBlocks/DestinationSol/blob/fa2a67e059b8bbd6d7a25836d04d999ffb0b860b/engine/src/main/java/org/destinationsol/game/ship/KnockBack.java#L83-L87