Some geometric shapes - Githubissues

MovingBlocks / TeraMath

Experimental standalone math and stuff. Automation category: Terasology Library

Apache License 2.0

13 stars 11 forks source link

Closed msteiger closed 9 years ago

msteiger commented 10 years ago

A few geometry classes that I currently use. At least two points are worth mentioning:

The class constructors reuse the Vector2d parameters directly instead of creating copies.
Rect2d is almost identical to engine's Rect2f. The contains() methods return true for x+w and y+h which is consistent with Rect2f, but is imho wrong. The right and bottom edges should the first ones to be outside, otherwise these points are inside two contiguous rectangles. This become even more of a problem for integer-based implementations. Some libs provide a method "touches" to catch these borderline cases.

Cervator commented 10 years ago

/me pokes @immortius

Cervator commented 9 years ago

By the way, is this ready to be merged? Been a while :-)

immortius commented 9 years ago

My comments:

I think the classes should be immutable, which means copying any provided Vectors.
I agree with the suggested changes to the floating point Rect classes contains method, and the addition of a touches method. I do feel that integer Rect classes should behave differently - two adjacent integer rectangles do not have overlapping edges, so there is no possibility of overlap.Two adjacent floating point Rectangles do have overlapping edges, which is why it is a good idea to drop two edges from the contains implementation.

msteiger commented 9 years ago

I've updated the PR and fixed all issues I know of. I'm closing this PR in favor of a new one that should go into develop not master.