Closed Cervator closed 9 years ago
Oh, and grabbing the note from GrowingFlora just for reference so we have it in an open issue
@msteiger - Note to myself: a few more Matrix4f constructors wouldn't hurt though
All issues should be fixed now - not sure the deer wouldn't move though.
Thanks for the quick and thorough response - all better now :-)
Took some thorough workspace cleaning to get fully up to speed, but even the deer works now, yay!
Going through the remainder of compile errors I can find in my mega-workspace after https://github.com/MovingBlocks/Terasology/pull/1417 was merged
Found:
QuaternionUtil.setEuler(yawPitch,...
in MinecartSystem.java and a few similar hits from TeraBullet which uses vecmath :-( Should we just convert it on the spot there? TeraBullet could be a beast to convert when we are thinking about replacing it some day. Class also uses .negate().new
object instantiation but review would be good (or maybe add a new clone method)I found some more places where Vecmath is still in use, yet in ways that are compatible, so those places don't get flagged as compile errors. Includes 39 hits in engine but maybe that's included on the future todo list?
I fixed a bunch of remaining non-issues where swapping to the new class allowed compilation to succeed :-)
Tested around and we might have a few new errors here and there to look at more. Deer doesn't move anywhere yet, maybe related to position calcs in Pathfinding