search

MovingBlocks / TeraMath

Experimental standalone math and stuff. Automation category: Terasology Library
Apache License 2.0
13 stars 11 forks source link

Some shapes #25

Closed msteiger closed 9 years ago

msteiger commented 9 years ago

Same content as #20, but aims to merge into develop.

Cervator commented 9 years ago

Thinking that's a ping for @immortius :-)

immortius commented 9 years ago

I've scattered in some comments. Nothing critical, mostly naming thoughts and clarification requests.

msteiger commented 9 years ago

Thanks! I've addressed all issues and added more tests. In particular I focused on float-based implementations and removed Rect2d entirely.

msteiger commented 9 years ago

A quick review of the latest commit would be great.

Once that is in, PolyWorld will compile with the main branch and could become part of the stable module set soon.

msteiger commented 9 years ago

All done. I renamed Rect2i.coords() to contents() and added a method ImmutableVector.createOrUse similar to how guava does it.

msteiger commented 9 years ago

I'd like to merge this if there are no more comments.

Cervator commented 9 years ago

:shipit: