search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.69k stars 1.34k forks source link

Double water transparency = no water! #114

Closed Cervator closed 4 years ago

Cervator commented 12 years ago

I ran across a spot where there were two big independent waterfalls and noticed that if I place myself with the closer waterfall overlapping the one in the background the overlapped region displays no water whatsoever.

Example: http://nanoware.org/pix/tera/DoubleWaterNoWater.png

Probably relates to the water transparency calculations getting in a fist-fight when they happen twice over the same spot :-)

Cervator commented 12 years ago

Sounds like this won't be an easy fix after all :-(

t3hk0d3 commented 12 years ago

This problem is appears because water blocks draws in same VBO as other solid blocks.

Imho water should be drawn in different VBO, or existing VBO generation should be fixed, to add edges between solid blocks and fluids.

Cervator commented 12 years ago

@begla put some details on IRC at one point leading to no easy fix with the current setup, but maybe a different setup would work then? As usual I'm not really going to be much use without wizardly powers, but hey... :-)

Maybe that would help with #183 too?

begla commented 12 years ago

Nope! Water has its own VBO already and this is not the solution to this problem anyway.

Cervator commented 12 years ago

Aw :-(

4Denthusiast commented 6 years ago

The picture in the initial post is no longer accessible, so I can't check the exact situation, but this seems to not be happening now so it might as well get closed. @Cervator?

Qwertygiy commented 5 years ago

Still occurs: image

4Denthusiast commented 5 years ago

The image @Qwertygiy posted shows one layer of water in each location, not none as Cervator described. If that's the issue, it's a duplicate of #3305 .

Cervator commented 4 years ago

Oh boy this is an old issue! Saw it by chance having been updated while looking for something else.

I think @Qwertygiy's example is subtle but may be showing staggered water blocks in two different places - hard to see and yeah it is a different issue.

I dug up the old image from my ancient webhost, which I guess must have broken the way its URLs work. Here it is again (look at that old school look!):

DoubleWaterNoWater

In that case the near waterfall is in the foreground and where it covers water in the background it looks like neither is being rendered at all, meaning you can see right down to the dirt under the second batch of water. Contrast with the side on the left where the near waterfall ends yet suddenly water in the background renders.

On the other hand off to the right it looks like the water does render, just really poorly, and maybe the foreground water does render even where it looks more like you're just looking at dirt in the background. Might be reaching into the territory #656 covers

As a more clear example of the latest here are two sets of screenies showing it better. Now you see it:

Terasology-191228191757-1152x720

Now you don't!

Terasology-191228191803-1152x720

But yeah, that looks like a duplicate of #3305 - so I'll go ahead and close this ancient issue in favor of that one and #656 :-)

(Fun fact: this was the 6th oldest open issue at the time it closed)