search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.69k stars 1.34k forks source link

Volumetric Fog broken #2246

Closed Yaksinikos closed 6 years ago

Yaksinikos commented 8 years ago

Terasology Alpha 64 Linux Mint 17-3 Java JDK 8 Installed using the launcher

I played a bit with the graphics, and recognized the following issues. If you open the graphic-setting while in a server/map, your unpicked/dropped items will not show any texture. The way to fix is to reload the map, reconnect to the server. Screenshot Mirror2

If you allow Volumetric Fog, the following happens, even after game restart it do not work. Screenshot Mirror2

emanuele3d commented 8 years ago

The issue with the untextured objects seems to be the same as in #966.

The issue with the Volumetric Fog is a new one, as until recently we had no graphic option for Volumetric Fog.

@Translator5: can you please:

@Cervator: please assign this issue to me for the time being. As I'm not going to work on it for a while at least, what do you think we should do? Remove the Volumetric Fog option altogether or leave there but perhaps label it as broken?

skaldarnar commented 8 years ago

@emanuele3d assigned the issue to you. Are you able to reproduce the issue/track it down to the option?

emanuele3d commented 8 years ago

@skaldarnar, I am able to reproduce. I'm not sure what you mean with "track it down to the option". =?

skaldarnar commented 8 years ago

eh, I shouldn't write comments when in a hurry :laughing: my thought was to find the spot where it breaks, i.e., why does the new option break the game. Here's a reference to the PR: https://github.com/MovingBlocks/Terasology/pull/2211

emanuele3d commented 8 years ago

By my understanding @tdgunes has enabled the turning on/off of a setting he found in the Rendering config. However, this doesn't mean the underlying effect, volumetric fog, is currently functional. Hence my question: assuming it can't be easily fixed, do we leave the option there, perhaps labeling it as "broken" or do we hide it from the video settings?

Cervator commented 8 years ago

Well, the option is already in the experimental section and defaulted to off, so I'm not losing sleep over it :-) We still even have an Oculus Rift toggle in there which has been broken for ages.

I think we should keep the options but if something is broken 100% maybe we should ghost out the checkbox to indicate "broken" entirely? Although I'm not sure we can inactivate a checkbox?

pollend commented 8 years ago

@Cervator I believe I resolve this in pull #2256 . can someone close this.

Yaksinikos commented 8 years ago

@pollend the volumetric fog is still an issue in dev. build #1.681 alpha 2016-03-30T05:13:51Z! The dropped-items are fixed!

So should I close this Issue?

Cervator commented 8 years ago

@Translator5 I think we should keep this open as volumetric fog is indeed broken. The other fix was covered by #966 which is now closed. I'll rename this a bit for clarity

I've also submitted #2268 to get the UI support for disabling the volumetric fog checkbox until it is working again.