Prevent joining multiplayer with registered names

ar0ne commented 6 years ago

What you were trying to do

I joined Unstable server twice with the same nickname. Then I changed name in one application, and system decided that I left the game and I don't see me in the list of Online players. Looks like anyone could join the game with my nickname and do whatever he wants to do:) I guess we should prevent joining the game with registered nicks. Don't we?

How to reproduce

Start 2 game instances
Check that you have the same nickname on both
Join the same server (e.g. Unstable server)
Change the nickname in menu
Push TAB and check that only one of players is present with updated nickname

screen shot 2018-04-12 at 19 52 20

ar0ne commented 6 years ago

screen shot 2018-04-12 at 20 17 34 screen shot 2018-04-12 at 20 21 11 Well, I make them different. And from time to time I see only one nick, or twice but the same. Maybe it's because I run them from one IP?

mkienenb commented 6 years ago

Maybe it has something to do with issue #3318 / PR #3329 where allClients is incomplete?

MovingBlocks / Terasology

Prevent joining multiplayer with registered names #3314

What you were trying to do

How to reproduce