search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.69k stars 1.34k forks source link

fix pmd warnings, codemetrics-2.1.0, gradle-8.4 #5146

Closed soloturn closed 1 year ago

soloturn commented 1 year ago

gradle-8.4 released, fully supports java-21. codemetrics-2.1.0 has the pmd rules inlined, so warnings are gone now. see https://github.com/MovingBlocks/TeraConfig/pull/19 . remove a couple of outdated TODOs. adjust a link in a comment to new gradle versions.

Cervator commented 1 year ago

Oh, and perhaps important since this talks about PMD: warnings during those scans were adding so much build time in Jenkins that I excluded PMD steps within the Jenkinsfile via https://github.com/MovingBlocks/Terasology/commit/f907533ede16322d2b6916947f27917a311b61b0 (although huh, the PMD line didn't show up as part of the main commit line) - if this fixes that and restores build times to a decent range I'd be happy to see it hooked back up.

soloturn commented 1 year ago

Oh, and perhaps important since this talks about PMD: warnings during those scans were adding so much build time in Jenkins that I excluded PMD steps within the Jenkinsfile via f907533 (although huh, the PMD line didn't show up as part of the main commit line) - if this fixes that and restores build times to a decent range I'd be happy to see it hooked back up.

there is a ticket saying logging got changed to finest which makes it 3 times slower: https://github.com/pmd/pmd/issues/1018 . but for me it does not make a huge difference, local. so i updated the pmd version as well now to 6.55.0, lastest before 7.0.0, just to be sure no known bugs are in. if you want, release https://github.com/MovingBlocks/TeraConfig/pull/22 this and i'll update codemetrics to it.

soloturn commented 1 year ago

this one could be merged now. updated codemetrics, so pmd warnings are gone as https://github.com/MovingBlocks/TeraConfig/pull/22 is used, thanks @jdrueckert !