Defunct graphics settings

MovingBlocks / Terasology

Terasology - open source voxel world

http://terasology.org

Apache License 2.0

3.63k stars 1.33k forks source link

Defunct graphics settings #5152

Open WeDoStuffUncorp opened 7 months ago

WeDoStuffUncorp commented 7 months ago

While testing Terasology's graphics settings recently, I found a few settings that didn't seem to work as intended or at all.

The following is a list of all of these settings, as well as notes on each one:

Clamp Lighting - no notes
Extra Lighting - as far as I can tell, it doesn't seem to actually add any extra lighting... may require further testing
:heavy_check_mark: Vignette - makes the screen slightly darker at the edges, but the effect isn't noticeable enough to bring any value
:heavy_check_mark: Eye-Adaptation - like vignette, the effect of the setting isn't noticeable enough, but I believe that if it can be upscaled then it could be useful
:heavy_check_mark: Bloom - doesn't seem to work, and strangely disables the Light Shafts setting while it's activated

AuroraBorealish commented 7 months ago

Additional graphical issue: Torches all flicker in unison with "Flickering lights" on, which is the default setting. Personally, this is quite jarring, and makes it so that no matter how many torches, it will be completely dark every 2 seconds or so, when inside a house with indoor lighting.

Imitater967 commented 2 months ago

About Vignette, we need to change the texture mannually at org/terasology/engine/assets/textures/vignette.png About the eye adaption, I already fixed it at https://github.com/Terasology/CoreRendering/pull/77 About the Bloom, exactly what you said. ExtraLightning is normalMapping, but we don't see any normalmap related document in the tutorial. ClampLightning is just a empy property and just usless, so I suggest remove clamplightning in both ui and Rendering Confing, bloom, extralightning just remove them in UI, because they are likely needed in the future.

Imitater967 commented 2 months ago

Additional graphical issue: Torches all flicker in unison with "Flickering lights" on, which is the default setting. Personally, this is quite jarring, and makes it so that no matter how many torches, it will be completely dark every 2 seconds or so, when inside a house with indoor lighting.

You can find related code at globalFunctionsFragIncl.glsl, the flickeringLightOffset seems separated perchunk, instead of perblock.

I think, we may add some parameter like waving the water .

forexample

Imitater967 commented 2 months ago

2 quest remain. remove clamp lightning from UI, rendering config and any related code you can find. investigate how to separate the flickering light offset per block instead of per chunk (we need to be considerate of the performance impact here, though - if it impacts performance noticably we probably don't want to merge that until we improved performance a bunch first)

jdrueckert commented 2 months ago

Eye-adaptation fixed by https://github.com/Terasology/CoreRendering/pull/77 Bloom fixed by https://github.com/Terasology/CoreRendering/pull/78 Vignette improved by https://github.com/Terasology/CoreRendering/pull/80

Thank you for the great work @Imitater967 :green_heart: