Update Ukrainian locale with current strings

MovingBlocks / Terasology

Terasology - open source voxel world

http://terasology.org

Apache License 2.0

3.69k stars 1.34k forks source link

Update Ukrainian locale with current strings #5156

Closed rzats closed 1 year ago

rzats commented 1 year ago

Contains

As usual, updates the menu_uk localization with a couple of changes:

Adds one missing string, translates one untranslated one.
Reworks a bunch of settings-related strings - since we have Ukrainian strings in large AAA games now, I can use them as a reference to see what terms everyone's using! (I referred to Baldur's Gate 3 for this one.)
Corrects a couple of other things, like ім'я (a name for a human) vs. назва (a name but for a thing).

How to test

Launch the game, switch the language to Ukrainian, then check out various UI screens to see if things look alright. Maybe look things over with Google Translate :)

Outstanding before merging

None!

rzats commented 1 year ago

https://github.com/MovingBlocks/Terasology/blob/develop/.github/workflows/project-autoadd.yml PROJECT_GITHUB_TOKEN needs to be refreshed I think? The related workflow is failing for a while :)

jdrueckert commented 1 year ago

https://github.com/MovingBlocks/Terasology/blob/develop/.github/workflows/project-autoadd.yml PROJECT_GITHUB_TOKEN needs to be refreshed I think? The related workflow is failing for a while :)

I refreshed the token earlier today (before your PR came in) but the action unfortunately doesn't work for PRs from forks...

rzats commented 1 year ago

@jdrueckert thanks for taking a look :) Seems like the CI is failing with some stuff that doesn't seem i18n-related: Integration Tests / org.terasology.engine.integrationenvironment.delay.DelayManagerTest.delayedActionIsTriggeredTest(ModuleTestingHelper) Integration Tests / org.terasology.engine.integrationenvironment.ExampleTest.testClientConnection() what's typically done about this?

jdrueckert commented 1 year ago

Seems like the CI is failing with some stuff that doesn't seem i18n-related: Integration Tests / org.terasology.engine.integrationenvironment.delay.DelayManagerTest.delayedActionIsTriggeredTest(ModuleTestingHelper) Integration Tests / org.terasology.engine.integrationenvironment.ExampleTest.testClientConnection() what's typically done about this?

Yup, that's correct, we have 1-2 sporadically failing integration tests. Usually, either a retrigger helps or we merge despite the failing integration test if it's unrelated which in your case it is. Had to update the branch anyways because another PR got merged, so let's see what Jenkins says this time :wink: If it fails the unrelated test again, I can merge the PR later anyways.