search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.64k stars 1.33k forks source link

qa: parametrize logger usages #5181

Closed jdrueckert closed 6 months ago

jdrueckert commented 7 months ago

Re-does MovingBlocks/Terasology#5173 (reverting its revert MovingBlocks/Terasology#5180)

jdrueckert commented 7 months ago

@soloturn let's split out the slf4j upgrade and any lazy log adjustments thus, the remaining changes can be merged until we get the slf4j upgrade to work

soloturn commented 7 months ago

how do you want me to get a commit in here? like this #5182 ?

jdrueckert commented 7 months ago

how do you want me to get a commit in here? like this #5182 ?

you should have permissions to work on branches on the original repo, not your fork 🤔 this should also allow you to checkout and commit on an existing branch...

if this is not the case, please tell me so I can recheck your permissions

the idea would be to remove the slf4j upgrade from this branch and open a new PR (targeting develop) with the removed changes

soloturn commented 7 months ago

no right

❯ git push
ERROR: Permission to MovingBlocks/Terasology.git denied to soloturn.
fatal: Could not read from remote repository.
jdrueckert commented 7 months ago

@soloturn you should've received an invitation to the ReviverWriteAccess GitHub team Becoming a member of that team provides you with privileges to push branches and commits to the MovingBlocks/Terasology and MovingBlocks/TeraConfig repos as well as manage issues and PRs.

soloturn commented 7 months ago

redone, there is one line less than in the original, failing one. engine/build.gradle stays on slf4j-1.7.36, @jdrueckert. for details see 7f4e40f06633b980d454c7c87de796572a09b8d9 and https://github.com/MovingBlocks/Terasology/pull/5182.