Terasology engine

[soloturn]

inttelij, checkstyle, pmd warnings removed:

• case of constants
• line length
• make fields final
• remove unnecessary toString()
• ordering of declarations
• unused fields
• simplify conditions

[soloturn]

is there a way to retrigger the jenkins build, apart from force pushing?

[BenjaminAmos]

Under the checks tab on GitHub you should be able to re-run the tests if they fail. That appears to trigger a Jenkins re-run, as of recently (give https://github.com/MovingBlocks/Terasology/pull/5188/checks?check_run_id=19397149388 a try, for example). Some of the core contributors can force retrigger a build from the Jenkins UI but this relies on being added to a manual whitelist in the Logistics repository right now. If you're on that list then you can sign-in to Jenkins with your GitHub account to do that.

[soloturn]

ok now checks are green. @BenjaminAmos @jdrueckert you mind merging?

[jdrueckert]

Under the checks tab on GitHub you should be able to re-run the tests if they fail. That appears to trigger a Jenkins re-run, as of recently (give https://github.com/MovingBlocks/Terasology/pull/5188/checks?check_run_id=19397149388 a try, for example). Some of the core contributors can force retrigger a build from the Jenkins UI but this relies on being added to a manual whitelist in the Logistics repository right now. If you're on that list then you can sign-in to Jenkins with your GitHub account to do that.

Alternatively, instead of force pushing, you can create an empty commit using the allow-empty parameter for git commit.

[soloturn]

apart from one, reverted as mentioned in your review @BenjaminAmos .

[soloturn]

@BenjaminAmos i did your requested change, but still it shows "change requested". it means you need to close this?