search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.64k stars 1.33k forks source link

sonar upgrade to 5.0.0 #5194

Closed soloturn closed 1 month ago

soloturn commented 6 months ago

the new default behavior of sonarscanner is to not compile any more, to permit easier re-run. it can be controlled by a flag. the default behavior changes from sonar 4.4.1 to sonar 5.0.0, as well the name of the flag is unlucky. see here for more explanation: https://community.sonarsource.com/t/sonarscanner-for-gradle-you-can-now-decide-when-to-compile

soloturn commented 6 months ago

this change does not work on jenkins. local, on root of the source code tree there was a gradle.properties, which is git-ignored. i deleted it, and it did not get recreated out of templates. how it is supposed to work to place it there and make it effective? i saw a task which does it on demand:

gradle copyInMissingTemplates
BenjaminAmos commented 6 months ago

According to https://community.sonarsource.com/t/sonar-gradle-skipcompile-is-not-working/102710/9, that setting may not exist for much longer. I think a proper solution would involve configuring a compile dependency in build-logic/src/main/kotlin/terasology-metrics.gradle.kts, as we do already for the extractConfig gradle task.

soloturn commented 6 months ago

making it draft, did not yet succeed in starting that copyInMissingTemplates task properly via dependency :(

jdrueckert commented 2 months ago

@soloturn are you planning to continue with this?

soloturn commented 2 months ago

no, not important any more, as sonar released a new version. updated to version 5 and dropped the rest of the change.