refactor: merge world config in setup screen - Githubissues

MovingBlocks / Terasology

Terasology - open source voxel world

http://terasology.org

Apache License 2.0

3.64k stars 1.32k forks source link

refactor: merge world config in setup screen #5226

Closed jdrueckert closed 2 months ago

jdrueckert commented 3 months ago

Contains

Continues Advanced Game Setup (AGS) overhaul started in #5118 and #5122. Merges WorldSetupScreen into UniverseSetupScreen.

Fixes #4810 as a side effect.

How to test

Start Terasology
Start creating a world
Go to Advanced Game Setup (AGS)
Continue to Universe Setup
Play around with the screen, check for unclear UI elements, unexpected UI behavior, etc.
Verify that the game can be started

Outstanding before merging

[x] Trigger a preview update when configuration is changed
[x] clean up code where necessary
[x] improve documentation where necessary

BenjaminAmos commented 2 months ago

There are a few things I noticed which might still need to be resolved after merging this:

The "Universe Set-up" screen still shows "World Pre-generation" as its title.
The text:

Pick a world generator. World Generators:

seems a bit redundant. Maybe just keep the World Generators: part?
- The Re-Roll button is not the same height as the seed text field.
- Headings between each world configuration option should be more clearly delineated (for example, having a box around each expandable section). This is likely a general issue with PropertyLayout however.