Closed Khaled-Dridi closed 6 months ago
Suprisingly, this works, although it does lead to a longer delay when switching screen modes.
There are a few things that I think could be improved here:
- Remove all modifications to the
.idea/kotlinc.xml
file (these changes should never have been committed)- Replace the duplicated code with a two-iteration for loop and maybe add a comment referencing Bug on trying to change display settings to windowed fullscreen #5228 to explain why this is being done.
hi i just did that can you check it https://github.com/MovingBlocks/Terasology/pull/5243
Contains
this PR fixes #5228 when windowed fullscreen is pressed ir will still show the task bar i fix that buy making it double click the windowed full screen so wit will change its state twice
How to test
go to setting go to video change to windowed then change to windowed fullscreen because previously when you press windowed then press windowed fullscreen it will keep the task bar
Outstanding before merging
If anything. You can use neat checkboxes! Feel free to delete if not needed