search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.64k stars 1.32k forks source link

Windowedfullscreen fix #5243

Closed Khaled-Dridi closed 1 month ago

Khaled-Dridi commented 1 month ago

this PR fixes #5228 when windowed full screen is pressed it will still show the task bar i fix that buy making it double click the windowed full screen so it will change its state twice (i used for loop for that)

How to test go to setting go to video change to windowed then change to windowed full screen because previously when you press windowed then press windowed fullscreen it will keep the task bar

Outstanding before merging If anything. You can use neat checkboxes! Feel free to delete if not needed

[no ] Need to consider use case x [no ] Still have to adjust the wiki doc [no ] Will need translation work

Khaled-Dridi commented 1 month ago

Thanks for fixing this! The changes here are mostly fine but I cannot accept supressing checkstyle warnings for no good reason. Please try and fix those first.

For future reference, you do not need to open a new pull request every time you make changes. You can just push new commits to this pull request's branch and they will been shown here.

can you rereview it I did what you told me to do and ty

BenjaminAmos commented 1 month ago

I was all ready to approve this earlier but after testing it again it does not appear to work anymore? I was looking through the changes and it is puzzling. Did you test this version before submitting it?

The only difference I can see from your last pull request is that the following line is not run twice anymore. Could that be related? https://github.com/MovingBlocks/Terasology/blob/072d20742eff71bc2f34f358af399b59ae2d375c/engine/src/main/java/org/terasology/engine/core/subsystem/lwjgl/LwjglDisplayDevice.java#L98

Khaled-Dridi commented 1 month ago

I was all ready to approve this earlier but after testing it again it does not appear to work anymore? I was looking through the changes and it is puzzling. Did you test this version before submitting it?

The only difference I can see from your last pull request is that the following line is not run twice anymore. Could that be related?

https://github.com/MovingBlocks/Terasology/blob/072d20742eff71bc2f34f358af399b59ae2d375c/engine/src/main/java/org/terasology/engine/core/subsystem/lwjgl/LwjglDisplayDevice.java#L98

yes i did test it and it worked for me i will check it again when i am next to my laptop

Khaled-Dridi commented 1 month ago

@BenjaminAmos hi there i found the problem and i posted a new commit if you can check it that would be great