MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.69k stars 1.34k forks source link

compilejava should create versioninfo file #5259

Closed soloturn closed 4 months ago

soloturn commented 4 months ago

versionInfo.properties was not created, depend on it when doing

gradle --console=plain clean extractConfig extractNatives distForLauncher testDist

not sure yet about Credits.md:

❯ find . -name Credits.md
./docs-pre-merge/Credits.md

which is not "docs" as written in build.gradle.kts

another question i'd have, what this TODO means?

//TODO: Remove this when gestalt can handle ProtectionDomain without classes (Resources)
skaldarnar commented 4 months ago

Previously (https://github.com/MovingBlocks/Terasology/blob/5eceac78293f8edbc84c1a2e6f60a648f8295800/engine/build.gradle) the dependency chain was

https://github.com/MovingBlocks/Terasology/blob/5eceac78293f8edbc84c1a2e6f60a648f8295800/engine/build.gradle#L270-L272

https://github.com/MovingBlocks/Terasology/blob/5eceac78293f8edbc84c1a2e6f60a648f8295800/engine/build.gradle#L264-L266

https://github.com/MovingBlocks/Terasology/blob/5eceac78293f8edbc84c1a2e6f60a648f8295800/engine/build.gradle#L254-L257

so we jumped through a bunch of hoopes to eventually included the version info file whenever we to compileJava. The chain still looks to be in place, but somehow the file is not found/copied/whatever?

I'll try to test this out later, currently just looking at the changes on Github...

soloturn commented 4 months ago

so we jumped through a bunch of hoopes to eventually included the version info file whenever we to compileJava. The chain still looks to be in place, but somehow the file is not found/copied/whatever?

yes, this looked unnecessary complicated, and, not sure why, but did not work any more. so i thought let the dependency be direct.