qa: address pmd findings

MovingBlocks / Terasology

Terasology - open source voxel world

http://terasology.org

Apache License 2.0

3.69k stars 1.34k forks source link

qa: address pmd findings #5274

Closed jdrueckert closed 1 month ago

jdrueckert commented 3 months ago

Contains

Fixes for the following PMD finding categories:

CollapsibleIfStatements
SimplifiedTernary
SystemPrintln
InvalidLogMessageFormat
AvoidBranchingStatementAsLastInLoop
ForLoopCanBeForeach
AvoidPrintStackTrace

How to test

Test that Terasology CoreGameplay world can still be started fine
Check PMD job in CI that there are no more findings for the above-listed finding categories

soloturn commented 1 month ago

@jdrueckert can you undraft it or split it please?

jdrueckert commented 1 month ago

@jdrueckert can you undraft it or split it please?

I fixed the open checkstyle issues, wrote a proper PR description and undrafted the PR. Please review in case you have time @soloturn :slightly_smiling_face: If you're okay with the changes, please feel free to approve and merge the PR, then I'll continue with fixing more PMD findings in another PR.