search

MovingBlocks / Terasology

Terasology - open source voxel world
http://terasology.org
Apache License 2.0
3.67k stars 1.34k forks source link

refactor: replaced all whitelist and blacklist occurences by allowlis… #5277

Open byhlel opened 1 week ago

byhlel commented 1 week ago

…t and blocklist

We want to demonstrate our openness and inclusiveness in our code

Resolves #5275

Contains

Resolves #5275

How to test

Everything works as before

Outstanding before merging

Cervator commented 6 days ago

This is eerily reminding me of #5276 - my apologies @byhlel for thinking you may also be a bot or some sort of AI-assisted PR generator, but I'd like to ask for some sort of sign of humanity before considering this PR.

Like just saying hello and what brought you here, and confirming that you've actually been able to run the game from source with the updates in place?

byhlel commented 6 days ago

Hey, I've just had some free time so I've been running around on good first issue. I launched the game on a VM but im not on the best setup currently so I'd actually some review on this. I'll try to rerun the game on another VM soon if no-one has time by then.

Also checking my profile would have reassured you on the latter. Have a good one!

Cervator commented 6 days ago

Oh phiew then - thanks for the quick reply, just a weird timing issue with the other PR and the barebones PR description. Maybe a tool that partially auto-created the PR out of a commit message or something?

I'd also be curious how you ran it on a VM, when trying in the past here that has gone ... poorly :-)

Any VM-induced performance issues aside so long as it builds and runs that's probably enough to call it validated 👍

Although, considering that a rename of config files is included for a headless server run, that might be worth a quick check as well. And I wonder if we had any part of that automated for the test server setup / stored game server images we use 🤔

This shouldn't be too bad to try out though, so maybe myself or another maintainer can check that soon. I'm on parental leave and have pretty minimal time, just spotted this by chance. I'll try to keep this in a tab near the top of my browser and see if I can get to it :-)

Much appreciated!

byhlel commented 6 days ago

No I just like to keep my commits as concise as possible and respecting the repo's guideline. So unfortunately (or fortunately) no tools neither to commit nor PR except from maybe lazyness to describe further the PR which was to me straightforward.

image

Seems fine to me but further review to make sure nothing was accidently broken might be relevant here.

byhlel commented 4 days ago

Yes thank you for pointing this out, hadn't thought much of backwards compatibility!