MovingBlocks / TerasologyLauncher

Terasology Launcher is the official launcher for the open source game Terasology.
http://terasology.org/
Apache License 2.0
154 stars 76 forks source link

fix: use custom start scripts instead of brittle patch files #639

Closed skaldarnar closed 3 years ago

skaldarnar commented 3 years ago

Okay, I've ended up going down the path suggested in #547 and adding custom templates based on the default start scripts provided by Gradle to this repo.

They contain a minimal addition to set JAVA_HOME local to the jre folder in APP_HOME. That way, the local JRE should be picked up when starting the launcher.

How to test

Resolves #547


Original PR description:

The start scripts are generated by gradlew startScripts, and the patch logic hooks up to it via doLast. I've updated the patch files by adjusting the .orig files as required, and then running diff -u on it (from within build/scripts/).

After this update, I at least don't see any rejections .rej anymore.

skaldarnar commented 3 years ago

Although this "solves" #547 I don't want to close that issue, as it describes the fact that this patch-workaround is quite brittle and will like break again in the future :see_no_evil:

My comment over there still holds - I want to move the launcher to jlink/jpackage rather than maintaining a custom copy of the start scripts. If anybody who understands Gradle a bit better (@keturn :wink:) happens to find the time for a PR to add customized scripts that contribution is very welcome.

jdrueckert commented 3 years ago

Launcher Fixes & Improvements

keturn commented 3 years ago

A note about that avro dependency: The fork has updated its documentation at https://github.com/zolyfarkas/avro and there is a new repo available for those, hosted by GitHub Packages.

The disadvantage is that using a GitHub Packages repository requires setting the credentials in your build environment: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-gradle-registry