search

MovingBlocks / TerasologyLauncher

Terasology Launcher is the official launcher for the open source game Terasology.
http://terasology.org/
Apache License 2.0
154 stars 76 forks source link

does not recognize stable releases as installed #651

Closed keturn closed 3 years ago

keturn commented 3 years ago

During playtest today, I successfully installed and ran stable release 5.1.1.

After restarting launcher, it did correctly use last-played-version [or did it?], but it thought it needed to re-install:

Menu bar shows download arrow for version 5.1.1

Logs indicate that wasn't just a cosmetic thing, it did unzip the distro again when I hit the button.

Originally posted by @keturn in https://github.com/MovingBlocks/TerasologyLauncher/issues/646#issuecomment-894854510

Cause

https://github.com/MovingBlocks/TerasologyLauncher/blob/4327450c1ef751910cedd27698fe8d9955ab4e90/src/main/java/org/terasology/launcher/repositories/GithubRepositoryAdapter.java#L59

The GithubRepositoryAdapter uses the engineVersion as the displayVersion. The list of releases in the UI is built from what it sees in the repositories. The installed files do have the right displayVersion, so they seem to not match.

keturn commented 3 years ago

We should think about Offline Mode (#198) while deciding how to address this. The fact that it depends on an online repo to tell us what is installed and ready to play locally is out-of-order.

keturn commented 3 years ago

fixed by #654 + #655