MovingBlocks / TerasologyLauncher

Terasology Launcher is the official launcher for the open source game Terasology.
http://terasology.org/
Apache License 2.0
154 stars 76 forks source link

feat: hide pre-releases by default #658

Closed skaldarnar closed 3 years ago

skaldarnar commented 3 years ago

This PR adds a new checkbox to the launcher settings view for the user to enable pre-releases. This checkbox is deselected by default. The launcher will only show pre-releases (including release candidates) when the user explicitly opts in to show them via the settings menu.

Somewhat addresses #479

skaldarnar commented 3 years ago

It seems to pick up the setting as saved on last run.

Also, switching the option on and off seems to work fine. If a pre-release version was selected when the option is disabled the box will stay empty. Even though the download button is enabled in that case, clicking it does not do anything...

skaldarnar commented 3 years ago

Properly fixing the situation that leaves the game release checkbox would require a bit (if not "a lot") more work.

We currently update the selection whenever we change the selected game profile, but this part is not properly hooked up with the rest of the properties.

https://github.com/MovingBlocks/TerasologyLauncher/blob/3a1bc1cbc004bb33ffb44e549c7418bb1def5c03/src/main/java/org/terasology/launcher/ui/ApplicationController.java#L177-L192

I'm not really sure how to best resolve this, and would prefer to clean up other parts of the code beforehand. For instance, we could improve a lot on LauncherSettings and BaseLauncherSettings by providing more Propertys there.