MovingBlocks / TerasologyLauncher

Terasology Launcher is the official launcher for the open source game Terasology.

http://terasology.org/

Apache License 2.0

154 stars 76 forks source link

[DON'T MERGE] PoC of migrating the launcher settings to JavaFX-property-based POJO #663

Closed skaldarnar closed 1 year ago

skaldarnar commented 3 years ago

:warning: DO NOT MERGE :warning:

This was the play ground to explore the migration of the launcher settings to a JavaFX-property-based POJO that can easily be persisted as JSON.

Some changes have already been extracted/re-applied in other PRs. Some other aspects are left as follow-ups or future improvements.

Related PRs

[x] based on #662
[x] simplify ApplicationController#update argument list ⇒ #664
[x] change Settings#load and Settings#store to only take the folder path and use default file names. ⇒ #666 If required, add variants Settings#store(Path, String) to allow to specify the (base) file name without extension.
[x] only apply 1:1 migration to FX-property-based settings object ⇒ #667

Follow-ups

[x] make use of FX bindings. To allow the SettingsController to reset to default or to discard changes we probably need to pass in the settings object as a property itself.
[x] clean-up LegacyLauncherSettings as follow-up
[ ] introduce FxUtils helper class

Based on #662

Contributes to #522

skaldarnar commented 1 year ago

All relevant changes have been merged in separate PRs.