search

MovingBlocks / TerasologyLauncher

Terasology Launcher is the official launcher for the open source game Terasology.
http://terasology.org/
Apache License 2.0
153 stars 76 forks source link

chore: update Gradle (7.1.1 >>> 7.5.1) and dependencies #685

Closed skaldarnar closed 1 year ago

skaldarnar commented 1 year ago

Contains

How to test

Build and run the launcher from source via Gradlew and ensure that everything is still working.

To generate or update the lockfiles for both the Java dependencies and the build plugin dependencies, run:

gradlew dependencies --write-locks

Outstanding before merging

Nothing.

jdrueckert commented 1 year ago

@skaldarnar For some reasons, gradle seems to have issues to resolve requirements for the pmdTest check:

> Task :pmdTest FAILED
   > Could not resolve ch.qos.logback:logback-classic:1.3.0-alpha16.
18 actionable tasks: 4 executed, 14 up-to-date
     Required by:
         project :
      > Module 'ch.qos.logback:logback-classic' has been rejected:
           Cannot select module with conflict on capability 'logging:slf4j-impl-capability:0' also provided by [org.spf4j:spf4j-slf4j-test:8.9.5(runtime)]
   > Could not resolve org.spf4j:spf4j-slf4j-test:8.9.5.
     Required by:
         project :
      > Module 'org.spf4j:spf4j-slf4j-test' has been rejected:
           Cannot select module with conflict on capability 'logging:slf4j-impl-capability:0' also provided by [ch.qos.logback:logback-classic:1.3.0-alpha16(runtime)]
   > Could not resolve org.slf4j:jcl-over-slf4j:1.7.33.
     Required by:
         project : > org.spf4j:spf4j-slf4j-test:8.9.5
      > Module 'org.slf4j:jcl-over-slf4j' has been rejected:
           Cannot select module with conflict on capability 'logging:jcl-api-capability:0' also provided by [commons-logging:commons-logging:1.2(runtime)]
   > Could not resolve commons-logging:commons-logging:1.2.
     Required by:
         project : > com.github.everit-org.json-schema:org.everit.json.schema:1.14.1 > commons-validator:commons-validator:1.7
         project : > com.vladsch.flexmark:flexmark-all:0.64.0 > com.vladsch.flexmark:flexmark-pdf-converter:0.64.0 > com.openhtmltopdf:openhtmltopdf-pdfbox:1.0.10 > org.apache.pdfbox:pdfbox:2.0.24
         project : > com.vladsch.flexmark:flexmark-all:0.64.0 > com.vladsch.flexmark:flexmark-pdf-converter:0.64.0 > com.openhtmltopdf:openhtmltopdf-pdfbox:1.0.10 > org.apache.pdfbox:xmpbox:2.0.24
         project : > com.vladsch.flexmark:flexmark-all:0.64.0 > com.vladsch.flexmark:flexmark-pdf-converter:0.64.0 > com.openhtmltopdf:openhtmltopdf-pdfbox:1.0.10 > org.apache.pdfbox:pdfbox:2.0.24 > org.apache.pdfbox:fontbox:2.0.24
      > Module 'commons-logging:commons-logging' has been rejected:
           Cannot select module with conflict on capability 'logging:jcl-api-capability:0' also provided by [org.slf4j:jcl-over-slf4j:1.7.33(runtime), org.slf4j:jcl-over-slf4j:1.7.36(runtime)]
skaldarnar commented 1 year ago

To be honest, the run of pmdTest on the main branch does not look ... clean either :thinking: 

> Task :pmdTest
The RuleSet rulesets/java/basic.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/braces.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/clone.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/finalizers.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/logging-java.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/migrating.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/sunsecure.xml has been deprecated and will be removed in PMD 7.0.0
The RuleSet rulesets/java/unusedcode.xml has been deprecated and will be removed in PMD 7.0.0
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
aktStatus is NULL: maximum Iterations exceeded, abort 1
69 PMD rule violations were found. See the report at: file:///home/skaldarnar/Code/movingblocks/terasologylauncher/build/reports/pmd/test.html
skaldarnar commented 1 year ago

We do have custom resolution strategies in place that look very related to the reported issues:

Cannot select module with conflict on capability 'logging:slf4j-impl-capability:0' also provided by [org.spf4j:spf4j-slf4j-test:8.9.5(runtime)]
...

https://github.com/MovingBlocks/TerasologyLauncher/blob/d54ced19a73aa95e44cd49d46801ba1055ff3f9c/build.gradle#L154-L164

@keturn Are those already applied to the pmdTest task? Why does it fail now after the update :thinking: (I don't understand how those libs and how we usethem are intertwined :see_no_evil: )