search

MovingBlocks / TerasologyLauncher

Terasology Launcher is the official launcher for the open source game Terasology.
http://terasology.org/
Apache License 2.0
154 stars 76 forks source link

Remove use of old Launcher Settings #704

Closed rzats closed 11 months ago

rzats commented 11 months ago

Contains

Fixes https://github.com/MovingBlocks/TerasologyLauncher/issues/686.

Looks like there's only really one file where the old LauncherSettings are still used incorrectly (that's SettingsController), and it's just to get a bunch of default values. So we retrieve these from the new class instead!

How to test

Affects userGameSettings and userJavaSettings (under "advanced options") so play around with these. I even added a couple of extra logging options just to be sure!

Outstanding before merging

None!

rzats commented 11 months ago

The original issue mentions:

LauncherSettings ... should only be used in a read-only mode to support previous releases of the launcher.

so I believe that's why :)