MovingBlocks / gestalt

A family of libraries providing a variety of core capabilities for use by games and game engines.
Apache License 2.0
27 stars 23 forks source link

gradle-6.5 --> gradle-8.2.1 #137

Closed soloturn closed 1 year ago

soloturn commented 1 year ago

Relates to https://github.com/MovingBlocks/Terasology/pull/5109 Relates to https://github.com/MovingBlocks/Terasology/pull/4653

Closes #116

jdrueckert commented 1 year ago

There's a bunch of additional stuff that @keturn did in #136 ... we might want to consider adopting those changes, or reopening #136 and integrating the changes of this PR in there. Edit: likely those changes are automatically generated/updated by gradle - I just don't know how to trigger that :thinking: Using gradlew after updating the version in gradlew-wrapper.properties didn't...

BenjaminAmos commented 1 year ago

The gradlew wrapper command updates the gradle wrapper files, including the gradlew and gradlew.bat scripts.

jdrueckert commented 1 year ago

Could not set unknown property 'classifier' for task ':gestalt-android:androidJavadocsJar' of type org.gradle.api.tasks.bundling.Jar

That sounds like the thing I also ran into... @BenjaminAmos made me aware of the fact that classifier was renamed to archiveClassifier

soloturn commented 1 year ago

thank you @jdrueckert, this error is gone now . @BenjaminAmos i set the path to the sdk and now it fails

❯ gradle --stacktrace
A problem occurred configuring project ':gestalt-android'.
> Failed to notify project evaluation listener.
   > org/gradle/api/plugins/MavenPlugin
* Exception is:
org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':gestalt-android'.
...
Caused by: org.gradle.internal.event.ListenerNotificationException: Failed to notify project evaluation listener.
        at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:111)
...
Caused by: java.lang.NoClassDefFoundError: org/gradle/api/plugins/MavenPlugin
        at com.android.build.gradle.internal.variant.VariantHelper.setupArchivesConfig(VariantHelper.java:47)
        at com.android.build.gradle.internal.LibraryTaskManager.createBundleTask(LibraryTaskManager.java:420)
        at com.android.build.gradle.internal.LibraryTaskManager.doCreateTasksForVariant(LibraryTaskManager.java:349)
        at com.android.build.gradle.internal.TaskManager.createTasksForVariant(TaskManager.java:487)
        at com.android.build.gradle.internal.TaskManager.createTasks(TaskManager.java:405)
        at com.android.build.gradle.internal.plugins.BasePlugin.createAndroidTasks(BasePlugin.java:595)
        at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:82)
        at com.android.build.gradle.internal.plugins.BasePlugin.lambda$createTasks$10(BasePlugin.java:498)
        at com.android.build.gradle.internal.crash.CrashReporting$afterEvaluate$1.execute(crash_reporting.kt:37)
        at com.android.build.gradle.internal.crash.CrashReporting$afterEvaluate$1.execute(crash_reporting.kt)
        at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:123)
        at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingAction$1.run(DefaultListenerBuildOperationDecorator.java:171)

i tried as well to get hints in the gradle discussion forum: https://discuss.gradle.org/t/gradle-6-8-2-gradle-8-2-1-java-lang-noclassdeffounderror-org-gradle-api-plugins-mavenplugin/46074

BenjaminAmos commented 1 year ago

@soloturn Is the Android Gradle Plugin version possibly too old now? 4.1.3 was designed to go with Gradle 6.5, so newer versions of Gradle might have broken things. You could try updating to a newer version of the android gradle plugin, maybe 7.4.1? It looks like versions 8.0 and above require Java 17, which isn't usable for us whilst we're still building with Java 11. https://github.com/MovingBlocks/gestalt/blob/911728ec00a5ccf5708427599c225916d96e7ffe/build.gradle#L12-L14

BenjaminAmos commented 1 year ago

This was finished off by #139. Thanks @soloturn!