search

MovingBlocks / gestalt

A family of libraries providing a variety of core capabilities for use by games and game engines.
Apache License 2.0
27 stars 23 forks source link

either this file is generated and ignored, or commited. but not both. #152

Closed soloturn closed 2 weeks ago

soloturn commented 2 weeks ago

remove jar file for testing module load, it is generated.

soloturn commented 2 weeks ago

The gitignore changes are fine but could you please remove your changes to the file gestalt-es-perf/test-modules/moduleF.jar?

i cannot follow? the PR does not change moduleF.jar, but deletes it. the purpose of gitignore is to make sure untracked files are not tracked. if the file is in the repo gitignore does nothing any more. gradle itself cannot yet produce byte-for-byte similar jar files.

references:

BenjaminAmos commented 2 weeks ago

You are correct and I misunderstood. GitHub was presenting the diff very misleadingly, so I thought you had shrunk the file rather than deleting it.