search

MovingBlocks / movingblocks.github.com

Terasology's Homepage hosted as a GitHub Page. On the page you can download Terasology, view related videos, go to the forum, etc.
https://terasology.org/
MIT License
7 stars 17 forks source link

Make blog link unique #242

Closed 5archoufa closed 3 months ago

5archoufa commented 4 months ago

Include date in URL

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jdrueckert commented 4 months ago

@5archoufa I locally tested this and noticed two issues:

  1. I don't think we need the entire date and timestamp in the blog link. Currently it's unlikely that we even write two blog posts in a month... Using the date should be enough even if the website picks up in blogs written again in the future.
  2. The blog preview cards on the front page don't properly navigate to the correct post when clicking on "Read more". Seems like they still use the "old" (not unique) links.

Also, prettier complains about some formatting issues. You can check the warnings out locally using yarn run format-check:js and run prettier on the affected files using yarn prettier <path/to/file> --write to fix the formatting issues.

Rukki13 commented 4 months ago

I've made a pull request here: #244

jdrueckert commented 3 months ago

I've made a pull request here: #244

Okay, then I'll close this one. But, just fyi, you don't need to open a new PR whenever you add changes. You can simply push to the same branch again and the PR should update.