search

MovnaTeam / movna

Open-source training application.
GNU General Public License v3.0
0 stars 1 forks source link

feat(25-location service status): Listen to location service status #33

Closed ronw98 closed 1 year ago

ronw98 commented 1 year ago

Retry watch location on service up Display alert when service is down Set persistant foreground notification and use app icon as notification icon

Alert on service disabled image

App icon in ui bar image

App icon in notification image

closes #25

BriceCroix commented 1 year ago

I do not understand the part with CustomColors, why the need of a class, why this name if it only defines colors related to warnings, and what is happening with the extensions on ThemeData.

Otherwise really good job on the location service !

ronw98 commented 1 year ago

I do not understand the part with CustomColors, why the need of a class, why this name if it only defines colors related to warnings, and what is happening with the extensions on ThemeData.

Otherwise really good job on the location service !

had not seen this message

It's basically been generated by the material theme builder https://m3.material.io/theme-builder#/custom

At the bottom left of the screen you can add one or more colors and the theme builder will harmonize it with the current theme and generate the base color, its container variant and the onColor and onSurface colors with light and dark variants

I only created one additionnal color but all add colors will be contained in the CustomColors class should we add some more

BriceCroix commented 1 year ago

Yes ok I had not realized this was generated code, the PR is fine with me then, good job !