search

Moxio / php-codesniffer-sniffs

Custom sniffs for PHP_CodeSniffer
MIT License
17 stars 10 forks source link

Bump slevomat dependency to allow 7.0.18 #12

Closed rmikalkenas closed 2 years ago

rmikalkenas commented 2 years ago

I would say it's kind of a bottleneck to keep slevomat/coding-standard dependency only for a few helpers for a single sniff DisallowDateTimeSniff. Maybe it would be wise to refactor this sniff to not use helpers from slevomat and get rid of this dependency, what do you think?

aboks commented 2 years ago

Thanks for your PR. I've merged it and released a v2.5.3 that can be used with slevomat/coding-standard v7.0.18.

We will look into options for replacing the slevomat helpers. Unfortunately they provide some logic that is quite hard to implement separately, and AFAIK there are no other libraries providing similar helpers. If you know a suitable replacement, we'd love to hear.