search

Moya / Moya

Network abstraction layer written in Swift.
https://moya.github.io
MIT License
15.09k stars 1.98k forks source link

Add xcode_summary to Danger to show build errors #1559

Closed SD10 closed 6 years ago

SD10 commented 6 years ago

One thing I hate about CI failing is I have to go and dig through the build log. It would be great if we could use xcode_summary to propagate test failures and build errors.

Here is an example of it being used at the EZSwiftExtensions repo

BasThomas commented 6 years ago

Oh wow, why have I not heard of this before?!

SD10 commented 6 years ago

@LucianoPAlmeida I'm tagging you because I see you setting this up for https://github.com/SwifterSwift/SwifterSwift/pull/498. If you get it working would you be so kind as to see if it can be applied to Moya too? ❤️

LucianoPAlmeida commented 6 years ago

For sure @SD10 :)) I just start running some tests to see how it works, let's see if I can put this to run there 😆

LucianoPAlmeida commented 6 years ago

I think I can try to make this one on this weekend :)) Let's see if we can make this run 😊

SD10 commented 6 years ago

This was resolve in #1680. Awesome work!