search

Moya / contributors

How the Moya org handles contributions
Other
57 stars 11 forks source link

Release Automation #5

Closed ashfurrow closed 8 years ago

ashfurrow commented 8 years ago

There are enough libraries I touch (Moya, this, and this) that all need similar releases.

It'd be fab if I could abstract Moya's current release script so this was a lot easier.

mpurland commented 8 years ago

Any luck with adding github release?

ashfurrow commented 8 years ago

TBH I've not had a chance to try it out yet. From your description, though, it looks like it should work!

ashfurrow commented 8 years ago

Took a look, seems a bit clumsy to use, but I'm going to give it a shot.

ashfurrow commented 8 years ago

So I looked into this, and Fastlane seems like the obvious answer. However, after reconstruct the existing Makefile tasks, we only save six lines of code. That's not significant enough to justify another dependency imo.

The current Rakefile is 101 lines, uses Ruby in a clever-but-obvious way, and invokes command line tools that we're already familiar with. Using the current Rakefile would be a good solution, but we still need to duplicate it in each library. That's probably not a huge deal.

So yeah, I'm thinking maybe just create a gist that contains a sort of 'template', and then link to that gist in all the Rakefiles to make it easy for other developers to reuse. Anyone else opposed?

orta commented 8 years ago

Probably better off making a library releasing gem at this point

ashfurrow commented 8 years ago

Yeah it's worth considering, especially if we're moving towards a common-ish way of doing things.

orta commented 8 years ago

Could be done here: https://github.com/CocoaPods/cocoapods-plugins/issues/52

segiddins commented 8 years ago

This was done via https://github.com/Moya/Moya/pull/456, right?

ashfurrow commented 8 years ago

@segiddins I believe so, thanks!