MozScout / scout-alexa

INACTIVE - http://mzl.la/ghe-archive - Scout Alexa Skill
Mozilla Public License 2.0
4 stars 3 forks source link

Remove skill strings from constants #131

Closed dylano closed 6 years ago

dylano commented 6 years ago

There were duplicate declarations for the Scout branding strings (scout_strings.js and constants.js). This change removes them from the constants class since they are now passed in to the skill directly via the brand file.

Updated the integration tests to also read strings from the brand file (as specified in the STRING_BRAND env variable) so now tests will pass with both the Scout and Pocket brand files.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 55


Totals Coverage Status
Change from base Build 50: 0.0%
Covered Lines: 379
Relevant Lines: 465

💛 - Coveralls