search

Mozart409 / blocky-frontend

A frontend for blocky
67 stars 6 forks source link

production not running, only localhost is allowed #13

Closed PrivatePuffin closed 1 year ago

PrivatePuffin commented 2 years ago

You need to uncomment the NODE_ENV section.

Currently this is only usefull if the user runs blocky AND the frontend on the same PC as their browser (as the browser makes calls to localhost), which basically makes this 100% useless, as almost no one would run that way.

PrivatePuffin commented 2 years ago

@Mozart409 the issue seems to be these commented-out lines: https://github.com/Mozart409/blocky-frontend/blob/7816f7d877f298f90934ea3b2f9eea0fafdbca1d/src/utils/api.ts#L7

Can you test if it's enough to just uncomment that and allow people to set the production mode? We're trying to integrate this (Although we understand it's a dev/poc, but it's better than nothing) into our Helm-Chart/SCALE-App, so it would be nice to have it actually... well... be useable.

Mozart409 commented 1 year ago

This is fixed in the latest version

Mozart409 commented 1 year ago

fixed in v0.4.0