search

Mozilla-Actions / sccache-action

sccache github action
Apache License 2.0
119 stars 24 forks source link

Set baseUrl for Octokit to make it work on GitHub Enterprise Server #144

Closed palloberg closed 1 month ago

palloberg commented 1 month ago

Fixes #143

sylvestre commented 1 month ago

thanks! do you need a new release?

palloberg commented 1 month ago

thanks! do you need a new release?

I think so, unless the dist/ files are rebuilt on the main branch so I can use Mozilla-Actions/sccache-action@main

palloberg commented 1 month ago

@sylvestre It looks like the dist/{setup,show_stats}/index.js files were not rebuilt before the release so in reality v0.0.5 and v0.0.6 are running the same code.

I guess the release process should include npm run build and adding the generated dist files to the repo. (And yeah, it's a terrible design choice for Typescript Actions that generated code must be committed to the repo).