search

Mozilla-Actions / sccache-action

sccache github action
Apache License 2.0
117 stars 22 forks source link

The dist files were not rebuilt for v0.0.6 or v0.0.5 #152

Open palloberg opened 2 weeks ago

palloberg commented 2 weeks ago

For the release of v0.0.6 and v0.0.5 of the action, the files in the dist/ folder were not built and committed to the repo. As those are the ones called when the action is executed (as defined in action.yml) the action is in effect running on the code built 5 months ago for v0.0.4.

The release process should probably be updated with a step to do npm run build and commit/push the changes in dist/ before tagging the release.

sylvestre commented 2 weeks ago

which files ? running npm run build only updates dist/setup/index.js is that expected?

palloberg commented 2 weeks ago

Not sure why the dist/show_stats/index.js is not rebuilt, but looking at package.json running build is calling build-dist which does update both dist/setup and dist/show_stats.