Closed hannahkane closed 7 years ago
@Melechuga @ScottDowne @natalieworth @TheoChevalier - can you please review the checklist above? Feel free to add items.
Looks good on the l10n side, just added Polish as it’s a requested locale
@Melechuga - what would you consider NOT essential to launch? These are the things that I think we could launch without:
What do you think?
Thanks for pulling this together, @hannahkane! I was thinking about it all, and if it's only a few days' delay in launching due to QA, I doubt it'll be a huge issue. I've slated the email to go out on Sept. 7th; do you think the site could be ready by then? If not, here are my notes on features we could launch without:
Thanks, @Melechuga. Perhaps we can get an updated estimate from @Pomax and @ScottDowne on Monday.
(The audio recording is on our side in that we have to make the recordings, but it sounds like that's moving along.)
@Melechuga @TheoChevalier @natalieworth - do you have time to help QA the staging site, per the items in the first comment above?
@hannahkane yes! I can def help. What's the staging site url? Where should comments/bugs be filed?
https://changecopyright-org-staging.herokuapp.com/en-US/
Please file bugs in this repo.
QA, EN Fix Copyright page (newsletter sign-up):
QA, EN Fix Copyright page, copy: Creator/Innovator section, the copy is "all the forms of expression that makes the internet wonderful." One grammar change -- "makes" should be "make"
QA, Fix Copyright page, copy: Creator/Innovator section, the copy is "all the forms of expression that makes the internet wonderful." One grammar change -- "makes" should be "make"
Thanks, fixed it
QA, ES Reforma de... page, links:
QA, ES Reforma de... page, newsletter sign-up: Screenshot shows the example in the email field ("Dirección de correo electrónico) doesn't fit in the box:
Also, it accepts an incomplete email address. The thank you/share page, though, is fantastic!
QA, ES Impacto page, copy (localization issues):
QA, ES site links: When on the landing page in ES ("Reforma de..."), clicking on either "Impacto" or "Llamar Ahora" at the top takes user to the EN page, instead of to the ES versions. Same when moving between pages -- everything takes you to the EN pages. Not sure if this is because of my IP, but this shouldn't be the case if someone has chosen their localized site.
Footer: the "Legal" and "Privacidad" links go the EN pages; should link to: Legal: https://www.mozilla.org/es-ES/about/legal/terms/mozilla/ Privacided: https://www.mozilla.org/es-ES/privacy/websites/ I'm assuming all the localized pages link to these as well; can we make sure they link to the respective ones for their languages? Footer: "Donar" also goes to the EN page; not sure if there is a localized version.
Those are okay, people will be properly redirected to the appropriate language. You’re being redirected to English because en-US is set as your preferred language in Preferences > Content > Language.
Under the Creator/Innovator section, the "For more detail..." link says "For more details..." -- should not have the s.
Fixed, thanks
3 out of the 4 "For more detail, read C4C’s facstheet (PDF, in English)." are in English. @TheoChevalier can you please add in the ES versions? Sections "Creador/innovador" and "Cientifico/bibliotecario" are still in EN; need ES versions.
Yup, it’s coming https://pontoon.mozilla.org/es/copyright-campaign/
QA, ES site links: When on the landing page in ES ("Reforma de..."), clicking on either "Impacto" or "Llamar Ahora" at the top takes user to the EN page, instead of to the ES versions. Same when moving between pages -- everything takes you to the EN pages. Not sure if this is because of my IP, but this shouldn't be the case if someone has chosen their localized site.
Dupe of https://github.com/MozillaFoundation/Advocacy/issues/1047
Thanks for the awesome QA, @Melechuga. I deleted a couple of your comments only because they'd been filed separately.
A bunch of these got fixed.
I see the largest issues left, after reading through this, to be:
Let me know if I missed anything and we can walk through it.
Sorry @ScottDowne I'm not seeing sticky button updates? Or is it coming? These aren't sticky for me yet:
I only put sticky on impact.
I've updated the checklist in the first comment of this ticket. @natalieworth @TheoChevalier and @Melechuga - if you feel the design, localization, and copy—respectively—are good for launch (we can continue to make small changes afterwards), please check the corresponding boxes in the checklist.
I don't know how to test the two remaining pieces in the call tool—checking to see that the user gets matched with the right MEP, and hears the right audio file. @Pomax - do you know how I can test that? Or are we not able to test until we push this live?
Also what I can’t test:
(+33) 0611223344
is accepted as well as (+33) 611223344
Otherwise, everything looks good to me on the localization side
Copy ok'd by me! The newsletter text is still a bit wonky tho (if that's by design, ignore me!):
Wonky signup css should be fixed in a bit.
Closing this ticket. Any additional changes should be filed as separate tickets.
Per mockups
QA for the build will include: