MozillaFoundation / Advocacy

For planning advocacy projects.
6 stars 0 forks source link

QA the site as it currently is #1088

Closed ScottDowne closed 6 years ago

ScottDowne commented 7 years ago

I'm mostly just looking for people to find things I have missed.

I'll be doing my own rotation of QA, but any help is appreciated.

Staging is here: https://advocacy-mozilla-org-st-pr-395.herokuapp.com/en-US/privacynotincluded

Comps are here: https://redpen.io/p/jbf0c36c8838f136ad

The product page isn't complete. Neither are images and copy, but still feel free to take a look at it.

Comment in this ticket with any issues you find however you see fit.

@natalieworth @beccaklam

hannahkane commented 7 years ago

Email modal shouldn't appear more than once in a session

ScottDowne commented 7 years ago

Right, I think we talked about a hard refresh makes it appear again?

hannahkane commented 7 years ago

I think that's probably fine, yeah.

hannahkane commented 7 years ago

Email field on modal doesn't validate email address format.

hannahkane commented 7 years ago

Should "m" in nav bar go somewhere? cc @beccaklam @natalieworth?

hannahkane commented 7 years ago

Legal links seem good to me. We might want to add a cc license. @caltrider - in your discussions with Legal, did they review the footer?

hannahkane commented 7 years ago
ScottDowne commented 7 years ago

@hannahkane Fixed the signup box showing up too often.

beccaklam commented 7 years ago

@ScottDowne Should I be QA-ing CSS right now?

beccaklam commented 7 years ago

@ScottDowne

@ScottDowne Landing Page - Desktop

More to come ... would it be easier if I made these changes?

HPaulJohnson commented 7 years ago

Some feedback from my initial pass at QA: Home Page

Why We Made This Guide Page

Email Modal

- Email modal checkbox disclaimer still has placeholder text displaying "I’m okay with mozilla handling my info as explained in {linkPrivacyNotice}" Edit by Théo: this got broken when I edited the strings, I have a fix in a pending pull request

Product Reviews

cc: @natalieworth @beccaklam @ScottDowne

natalieworth commented 7 years ago

Can we update the images for the header and the footer too (header takes a while for me to load cause it's not the down-sized version):

cc @ScottDowne

HPaulJohnson commented 7 years ago

A few more things on main nav:

HPaulJohnson commented 7 years ago

@ScottDowne Thinking about prioritization of the technical tasks still to be addressed, here's where I'd start:

ScottDowne commented 7 years ago

@HPaulJohnson The first item, "CSS changes" is too much for one task and needs to be broken down a bit. I remember a lot of requested changes.

beccaklam commented 7 years ago

@ScottDowne based on QA ask to add the 'privacy not included' logo to subsequent pages. Designs for this: https://redpen.io/p/gr44a4589bde3fdc12 Basically when the user scrolls pass the large landing page with the title "privacy not included" could the logo transition to sit in the header?

@natalieworth Need to figure out mobile direction for this which is trickier given less real estate: https://redpen.io/p/gr44a4589bde3fdc12 (last three redpens) do you have a preference?

beccaklam commented 7 years ago

@ScottDowne Re: QA on making the landing page more conducive to scrolling/more action to get the user to scroll, could we animate the arrow like this: https://codepen.io/rightblog/pen/EagNMN?q=animated+arrow&limit=all&type=type-pens or like this: https://codepen.io/mfritsch/pen/VYdeEE?q=animated+arrow&limit=all&type=type-pens

caltrider commented 7 years ago

@ScottDowne On the tile category page it reads "Why we made the guide' and on the actual page with that story it reads "Why we made this guide." Let's standardize to "Why we made this guide"

TheoChevalier commented 7 years ago

@caltrider On Friday I remember we wanted to update the categories on the homepage to use a verb, should we go with “Browse Game Consoles”, “Browse Home Hubs”, etc?

caltrider commented 7 years ago

Couple on things on the "Why we made this guide" page @ScottDowne @HPaulJohnson @beccaklam

ScottDowne commented 7 years ago

We still have a dead link I need a link target for, which I was told is something @brettgaylor has?

@brettgaylor The site has a link for "Read more from our partners at Gizmodo and Univision" which I'm not sure where it should go, and I think people mentioned you had it? If not, sorry for the distraction.

caltrider commented 7 years ago

@TheoChevalier Yes! That works great for the categories. Please do that and let @ScottDowne and @beccaklam when they are ready to update. Thank you!

tlasadea commented 7 years ago

@TheoChevalier @caltrider @HPaulJohnson here's the copy QA sheet I was talking about on the call: https://docs.google.com/spreadsheets/d/1Au0W0lMzUevwW8HDoGDMjx1gXshTA2Js77MDqUnMT0I/edit#gid=992855100

TheoChevalier commented 7 years ago

@tlasadea @caltrider @HPaulJohnson Copy has been updated with the latest changes in this ticket + the QA sheet, if there’s more just ping me

HPaulJohnson commented 7 years ago

Recap of outstanding items from our call this morning:

Site-wide

Homepage

Why We Made This Guide Page

Product Category Pages

Product Pages

tlasadea commented 7 years ago

On Safari (version 11.0) the CSS looks off and there is some weird stuff happening with the initial copy on the homepage. @ScottDowne @beccaklam @natalieworth

screen shot 2017-11-01 at 11 28 06

ScottDowne commented 7 years ago

@tlasadea thanks for pointing this out. I can look into it.

caltrider commented 7 years ago

On the category page with all the tiles, exercise is spelled wrong on "health & exercise".
Also, on the product pages, should we capitalize Camera, Microphone, and Track Location? cc: @ScottDowne @beccaklam @natalieworth @HPaulJohnson

caltrider commented 7 years ago

@ScottDowne Here are the links for the "Why We Made This Guide" post:

Link to our IoT survey blog post (in the first graph): https://medium.com/mozilla-internet-citizen/10-fascinating-things-we-learned-when-we-asked-the-world-how-connected-are-you-2c9601c36ef0

Link to the Consumer Reports Digital Standard (in the Consumer Reports graph): https://www.thedigitalstandard.org/

beccaklam commented 7 years ago

@ScottDowne Here's the redpen: https://redpen.io/p/gr44a4589bde3fdc12 for adding the "privacy not included" logo to the header for both desktop and mobile. You will also find the design for the updated review page in there. We decided to go with a "yes and no" system and using a red/green system to denote whether a yes or no is good or bad. Does that make sense? It may take some inferring on your part to figure out what is good or bad unless @caltrider @HPaulJohnson know of someone with capacity and knowledge who can go into the reviews and denote whether something is good or bad? cc: @natalieworth

HPaulJohnson commented 7 years ago

@beccaklam - these all look good to me. let's move forward with this direction.

HPaulJohnson commented 7 years ago

@ScottDowne i'm getting the scrambled text on scroll (per Temi's comment above) in mobile chrome as well.

ScottDowne commented 7 years ago

Safari stuff should be fixed.

HPaulJohnson commented 7 years ago

@ScottDowne that fixed it in mobile/chrome too.

HPaulJohnson commented 7 years ago

@ScottDowne note that I added a new, small change to the breadcrumb nav in the master list of outstanding updates above.

ScottDowne commented 7 years ago

@HPaulJohnson That might be tricky. The hamburger menu isn't a link, it's some js functionality. (which is how we get the transition) that you can toggle on and off. I cannot make a link work like it and still work like a link.

natalieworth commented 7 years ago

Images are here: https://drive.google.com/drive/u/0/folders/0B20-0lpP23c0NXJXMTRUSGRTV3M

HPaulJohnson commented 7 years ago

Per our call this a.m., here's the final list of things that will carry us to the homestretch:

P1

P2

cc: @ScottDowne @beccaklam @natalieworth @caltrider

HPaulJohnson commented 7 years ago

@ScottDowne created ticket #1096 to track progress moving this site to staging, then production.

HPaulJohnson commented 7 years ago
brettgaylor commented 7 years ago
beccaklam commented 7 years ago
natalieworth commented 7 years ago
HPaulJohnson commented 7 years ago
natalieworth commented 7 years ago

Share progress images are here https://drive.google.com/drive/folders/0B20-0lpP23c0SGZGYTA2Ul9abFk?usp=sharing

HPaulJohnson commented 7 years ago

thanks, @natalieworth already updated share progress buttons with these.

TheoChevalier commented 7 years ago
HPaulJohnson commented 7 years ago
HPaulJohnson commented 7 years ago
HPaulJohnson commented 7 years ago

https://advocacy.mofostaging.net/en-US/privacynotincluded/category/gadgetsgizmos/automaticpro