MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
389 stars 153 forks source link

Streamline type styles #1208

Closed kristinashu closed 6 years ago

kristinashu commented 6 years ago

Goals:

Steps:

In Sketch, @taisdesouzalessa has made some handy comments on how the type styles aren't quite right.

kristinashu commented 6 years ago

Any suggestions on how we could see where exactly a type style is being used? Would be great to identify if a style is only used in one spot.

cc @gvn

kristinashu commented 6 years ago

I'm putting this into a spreadsheet instead of Redpen https://docs.google.com/spreadsheets/d/1Z1oScv_5NfhGGkFg6nH-_16dKWSyPcNhrKdA5E_QwIk/edit?usp=sharing

taisdesouzalessa commented 6 years ago

@gvn for now the flow we are using to see where the styles are being used is:

  1. See the name of the class of the type style. (e.g.: "h1-white")
  2. Go to our local version of the site (both Kristina and I have a cloned version of the site in our machines)
  3. Using Sublime, we search in all docs for instances of the clas
  4. Then we see the pages in which the class is being used (index, 404, about) and so on

UPDATE: if we search for the class name without the "." it seems it is more effective

image

Not sure this is the most effective flow so if you have any other suggestion on how to quickly see all instances of a determined style that exist on the site, please let us know :)

kristinashu commented 6 years ago

I'm finding it hard to tell where it's being used. This is an example search result:

image image
kristinashu commented 6 years ago

I've filled out the spreadsheet and I think we can actually get rid of a bunch of styles!

@taisdesouzalessa @gvn can you please review and double check everything? https://docs.google.com/spreadsheets/d/1Z1oScv_5NfhGGkFg6nH-_16dKWSyPcNhrKdA5E_QwIk/edit#gid=0

kristinashu commented 6 years ago

This is done! It's amazing! I'm so happy about it! Thank you so much @mmmavis and @taisdesouzalessa!