MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
387 stars 153 forks source link

PNI - Address @todo in JS files in `source/js/buyers-guide/search/` #12870

Open data-sync-user opened 2 weeks ago

data-sync-user commented 2 weeks ago

I recently added JSDoc-style docs to code in the PNI search directory as well as left notes for action items. Some easy ones involve file/function renaming (for example, this) and some require more in-depth refactor (like this).

To find the list of todos,

[~accountid:712020:1c9d572d-29f2-46cd-bfed-328f5b8b2c36] I think the above work should be broken into two tasks - one for the straightforward tasks and one for the in-depth refactor. It would also be better if we complete this work first before visiting https://mozilla-hub.atlassian.net/browse/TP1-257 again. Please let me know if this approach sounds good to you. I can turn this ticket into an epic and create individual task tickets.

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 weeks ago

➤ Simon Acosta Torres commented:

Mavis Ou I agree on separating this into two multiple tasks. I also blocked https://mozilla-hub.atlassian.net/browse/TP1-257 ( https://mozilla-hub.atlassian.net/browse/TP1-257|smart-link ) with this ticket so we would know that work shouldn’t be tackle until this is completed. Thank you!