MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
389 stars 153 forks source link

Discuss enhancements to Pulse component on Wagtail #1460

Closed xmatthewx closed 6 years ago

xmatthewx commented 6 years ago

Currently, wagtail allows us to pull projects from Pulse to site pages with a search query. Let's discuss refinements and enhancements. @gvn @kristinashu @mmmavis For example, we could add option to filter by one or more issues. Also, we'd like to enable authors to pull People (such as mozfest speakers).

image

cc @gideonthomas @alanmoo

xmatthewx commented 6 years ago

Currently, it allows for "no maximum" in number of results. That seems dangerous. Is it still limited by API? Paginated? I'd cap it at 48 and maybe insert a button to "more" if the limit is reached.

People

Projects

Anything missing?

gvn commented 6 years ago

We probably shouldn't require search terms. Currently the homepage is searching with an empty query to show all the featured projects. This is only working because it's not a Wagtail-created instance of the component.

xmatthewx commented 6 years ago

Another use case: people often want to show things by year. Could the Projects component filter by date range? Seems reasonable, though API might not yet support that.

gvn commented 6 years ago

We can sort what we get back by date, but I'm not sure if we can fetch in particular date ranges.

Also, the max is now completely up to the user but if it isn't set it defaults to 48. I definitely think we should add pagination to the component. I'm happy to work on that if you want to file it.

xmatthewx commented 6 years ago

Do you mean a separate issue for pagination?

Should we have one issue for a new people component, one for project component improvements? How do the feature lists above look to you? I wonder if we should have a meeting with @alanmoo and @gideonthomas to settle on scope and requirements.

gvn commented 6 years ago

Let's create implementation tickets for each component with requirements inside. I think both will require design as well.

alanmoo commented 6 years ago

Based on the features Matthew is requesting, @gvn why don't you create the tickets with proposed technical changes that would best meet the needs? Put in the things that are most reasonable to do (lowest effort/biggest reward) so that we can continue the conversation from there. Designers need more information on what's possible so that we can move forward on this in a sensible way.

gvn commented 6 years ago

Honestly that seems a little backward to me. Most things are technically possible. I'd like to see what Design would like to do even if it's just wireframes and then I can always give feedback on that. @xmatthewx does that sound reasonable?

xmatthewx commented 6 years ago

For Projects, I don't think need to change anything on the frontend. So, we'll just need to mock-up admin for the component, which should be quick and easy based on the list above. Let's start there. After we land that, we can move onto a People component.

gvn commented 6 years ago

We should really add pagination to the projects component though, right? Can we have a designer comp that?

gideonthomas commented 6 years ago

+1 to adding pagination. Chatting with Abby, it's a pretty core requirement to events such as the global sprint. I don't think there are any performance considerations if we're paginating the entries.

xmatthewx commented 6 years ago

@taisdesouzalessa is going to mockup the admin components based on the lists above

xmatthewx commented 6 years ago

I'm going to open a new ticket for pagination. I'm not convinced we have enough use cases to justify the feature.

taisdesouzalessa commented 6 years ago

Here is the comp for the Projects component. I have a question related to tags, help needed and issues: will we display them in the front end as well? If we are showing them in the front end we may consider limiting the number of tags. Otherwise it can become very long! See example here (scroll to the side to see the front-end view)

https://redpen.io/xd85179b04f4b56419

UPDATE! - talked to @kristinashu about this component and she feels we are adding too many options to them, which I agree. We were wondering what are the use cases for tags and help categories, for instance. @xmatthewx let's chat about it after the stand up tomorrow? The 3 of us.

taisdesouzalessa commented 6 years ago

@xmatthewx for the People component, we currently don't display year on the Pulse profile. However, we do that for Fellows. We display different things for people depending on the context (if Fellows, Pulse or People Page). I made a list of things we display for each scenario: https://redpen.io/hd89f6b8037526f1a7

Here it is in a spreadsheet format

I feel we should define what we want to display first so I can mockup the CMS component, does that make sense? Maybe I should open a new ticket just for this discussion?

xmatthewx commented 6 years ago

Great progress. @taisdesouzalessa - Let's open 3 new tickets and then close this one. I think it's job is done.

1) implement project component admin 2) discuss people card frontend 2) plan people component admin

Let's wrap up and handover the 1st one before we go too far with 2 and 3. We're likely to learn a few things that will impact how we'll handle that.

taisdesouzalessa commented 6 years ago

Tickets are here:

  1. implement project component admin #1542
  2. discuss people card frontend #1543
  3. plan people component admin #1544

Closing this ticket.