MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
389 stars 153 forks source link

People page / front end of CMS issues #149

Closed hannahkane closed 7 years ago

hannahkane commented 7 years ago

cc @sabrinang @taisdesouzalessa

hannahkane commented 7 years ago

I'd prioritize fixing the "no image available" issue, because that doesn't look great. Otherwise, I don't think these things are blockers to soft launch.

cadecairos commented 7 years ago

in the case where there's no partner logo, should not display an "image not available" image

This is related to the admin interface not enforcing it as a required field. We'll file an issue to change that

gvn commented 7 years ago

Well, I don't think we should make partner logo required because not everyone will have one unless I'm mistaken @hannahkane ?

We can just suppress the "Image Not Available" visual on the front end if there's no logo. <- Logo is from Django

gvn commented 7 years ago

Since Alan is traveling I'm going to look into fixing this.

sabrinang commented 7 years ago

From issue https://github.com/mozilla/network/issues/100#issuecomment-284528827, it was mentioned that "People on Partners tab also get a logo, BUT only when the new logo column is highlight bright green too." so I believe we display around 10 of those approved partner orgs for the highlighted green people but I am unsure about that status on the rest.

hannahkane commented 7 years ago

Yes, partner logo should not be required, but "image not available" image should be suppressed.

gvn commented 7 years ago

I've identified a few issues with the JSON being emitted from Django:

@gideonthomas @cadecairos :

featured isn't being emitted on any of the items returned. Is this because none are featured or does that property not exist in Django? This isn't affecting front end other than no cards being featured.

links is formed differently in the data from Django. This is causing no links to display in the front end.

Django:

    "links": [
      {
        "url": "https://storyengine.io/stories/decentralization/joe-mcnamee/",
        "name": "Story Blog"
      }
    ],

Expected:

      "links": {
        "type": "object",
        "properties": {
          "twitter": {
            "type": "string"
          },
          "linkedIn": {
            "type": "string"
          }
        }
      },
gvn commented 7 years ago

Looks like only featured cards are "flippable", so once the featured property is set to true on a person the flipping should work as expected.

gvn commented 7 years ago

Links will just not render with the current structure coming out of Django. Will require a refactor of FE to display.

gideonthomas commented 7 years ago

Will make the above fixes! Thanks for showing the diff, makes it much easier!

hannahkane commented 7 years ago

OK, as per Gideon's comment, the formatting fix for the bio field is a front-end fix.

Dang, I did a bad job of filing issues in the right repos. Sorry!

gvn commented 7 years ago

The only things remaining to do from my perspective are:

Since all the functional issues have been resolved I'm dropping this to p1.

hannahkane commented 7 years ago

Thanks, @gvn. I think we can require images of the people themselves. I didn't see an image for Georgia in the folder, though I do see a link to one in the spreadsheet. @sabrinang - can you please advise - do we have a photo of Georgia to use?

gvn commented 7 years ago

I'm suggesting that we do the same thing we do for logos when they're unavailable, which is return null from Django and not show a placeholder on the front end.

For the moment if we can just put Georgia's photo in then we can address that point after launch.

hannahkane commented 7 years ago

Thanks, @gvn. I understood what you're suggesting. I don't think we will want to have profiles without an image of the person (I could be wrong about that), so I was counter-suggesting that we make it required to have a non-default image there. But agree we can table this until later.

gvn commented 7 years ago

Ah, ok. If we want to make the profile photo a required field that precludes the need for any front-end refactoring.

sabrinang commented 7 years ago

@hannahkane I updated the folder (to include Georgia and Daniel) https://drive.google.com/drive/folders/0B4Q8pzCpDS_eUzFlYnZ0TGpOUG8?usp=sharing

taisdesouzalessa commented 7 years ago

This is so nice to see!

Besides the items @gvn added to the checklist, there are some visual elements present in the comp that should be added to the page:

I am not sure about the priorities of those changes, definitely not an MVP.

I agree with @hannahkane that the pictures should be a requirement because this page is to highlight people of the Network and seeing their faces helps the connection to be established.

Last, sorry if I missed it, but will we be able to manually sort the people to control how the grid shows up? For instance, it would be nice to have another person beside Teon

hannahkane commented 7 years ago

@taisdesouzalessa - we can sort using the django interface. I'm happy to make any adjustments you'd like, or you can go in yourself, but know that I'll be adding a few more people today.

hannahkane commented 7 years ago

thanks, @sabrinang, for the images!

hannahkane commented 7 years ago

just re-ordered the cards, so should look better once we rebuild

taisdesouzalessa commented 7 years ago

That's awesome, Hannah. Thank you so much for that :). Let me know if you need any help on adding more people or sorting cards.

hannahkane commented 7 years ago
gvn commented 7 years ago

LinkedIn is fixed on staging

xmatthewx commented 7 years ago

@hannahkane - seems like this is all fixed. true? ready to close?

hannahkane commented 7 years ago

There are some unchecked boxes here, but I'll close this and open a new issue instead.