MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
389 stars 153 forks source link

clean up primary_heroguts.html a little #3166

Closed Pomax closed 4 years ago

Pomax commented 5 years ago

we did some cleanup in the mozfest app to yield:

 <div class="banner">
    {% if page.banner %}
      {% if homepage %}
        {% include "./homepage_banner.html" with page=page %}
        {% include "../fragments/hero/large.html" with page=page %}
      {% else %}
        {% include "../fragments/hero/normal.html" with page=page %}
      {% endif %}
    {% else %}
    <img src="/_images/mozfest/Festival Banner 1.jpg" alt="">
    {% endif %}
  </div>

rather than a huge block of HTML, with the includes in their own nice-and-terse files. That's worth doing for the foundation site itself, too

Pomax commented 4 years ago

I'll see if this is still something we need to do.